From 0d9ae7a977486aaf30c81d474bf8e0d5ed9bab5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gell=C3=A9rt=20Peresztegi-Nagy?= Date: Fri, 10 May 2024 17:47:51 +0100 Subject: [PATCH] cmake: pin seastar to c++20 The combination of libstdc++ >= 13, c++ >= 23 and clang 16 has this bug that caused compilation issues on ubuntu: * https://github.com/llvm/llvm-project/issues/61415 This does not cause any compilation errors on fedora because fedora has a patch version higher gcc and libstdc++ version. Seastar recently upgraded to using c++23, so this is why we are seeing this error now. --- cmake/dependencies.cmake | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmake/dependencies.cmake b/cmake/dependencies.cmake index df9869552dd70..f4b58498fb978 100644 --- a/cmake/dependencies.cmake +++ b/cmake/dependencies.cmake @@ -37,11 +37,13 @@ fetch_dep(fmt # the add_subdirectory method of using Seastar. set(Seastar_TESTING ON CACHE BOOL "" FORCE) set(Seastar_API_LEVEL 6 CACHE STRING "" FORCE) +set(CMAKE_CXX_STANDARD 20) set(Seastar_CXX_FLAGS -Wno-error) fetch_dep(seastar REPO https://github.com/redpanda-data/seastar.git TAG v24.2.x PATCH_COMMAND sed -i "s/add_subdirectory (tests/# add_subdirectory (tests/g" CMakeLists.txt) +set(CMAKE_CXX_STANDARD 20) fetch_dep(avro REPO https://github.com/redpanda-data/avro