Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACLDelUser to rueidiscompat #740

Closed
rueian opened this issue Feb 7, 2025 · 1 comment · Fixed by #747
Closed

Add ACLDelUser to rueidiscompat #740

rueian opened this issue Feb 7, 2025 · 1 comment · Fixed by #747
Assignees
Labels
feature good first issue Good for newcomers

Comments

@rueian
Copy link
Collaborator

rueian commented Feb 7, 2025

Take the below ACLDryRun as an example to implement the new function in rueidiscompat that provides the same interface as go-redis:

func (c *Compat) ACLDryRun(ctx context.Context, username string, command ...any) *StringCmd {
cmd := c.client.B().AclDryrun().Username(username).Command(command[0].(string)).Arg(argsToSlice(command[1:])...).Build()
resp := c.client.Do(ctx, cmd)
return newStringCmd(resp)
}

func (c *Pipeline) ACLDryRun(ctx context.Context, username string, command ...any) *StringCmd {
ret := c.comp.ACLDryRun(ctx, username, command...)
c.rets = append(c.rets, ret)
return ret
}

See the parent issue for more details #736.

@rueian rueian changed the title ACLDelUser Add ACLDelUser to rueidiscompat Feb 7, 2025
@rueian rueian added good first issue Good for newcomers feature labels Feb 7, 2025
@win5923
Copy link
Contributor

win5923 commented Feb 9, 2025

Hi @rueian, may i take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants