Hiredis v1.2.0 HIREDIS_SONAME number is incorrect

[joydeep2024]

In file hiredis.h for v1.2.0 we have the following
#define HIREDIS_MAJOR 1
#define HIREDIS_MINOR 2
#define HIREDIS_PATCH 0
#define HIREDIS_SONAME 1.1.0

Shouldn't this be
#define HIREDIS_MAJOR 1
#define HIREDIS_MINOR 2
#define HIREDIS_PATCH 0
#define HIREDIS_SONAME 1.2.0

[michael-grunder]

The reason the v1.2.0 SONAME is 1.1.0 is that hiredis v1.2.0 is 100% API and API compatible with v1.1.0.

Or to put differently, clients don't have to recompile their binaries if they upgrade from v1.1.0 to v1.2.0.

Technically I think we would actually want to drop minor and patch from the soname (to comply with normal linux conventions) but we did it in a weird way from the very early versions of hiredis.