-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't we set overcommit_memory=1? #19
Comments
This was discussed in #14. But I am open to good reasons. |
It wouldn't be possible to set this via a Also, I think this sets it system-wide, not just for the container, so I'd be wary of setting this in the entrypoint too (which would be the only place it could possibly even work). |
so, is this a limitation of linux containers? |
+1 for |
+1 RUN sysctl vm.overcommit_memory=1 |
Yes. Some |
Maybe related: boot2docker/boot2docker#1083 |
See also moby/moby#4717 -- there isn't anything we can do from the Docker perspective except document how to set this value on the host (which would go into https://github.com/docker-library/docs/blob/master/redis/content.md; a PR would be awesome). |
moby/moby#19265 just merged. Can this solve the issue? |
Very cool -- that won't make it into 1.11 (being released today), but we could document for users of 1.12+ how they can use |
I don't think |
@justincormack aww, fair enough -- I suppose that means there's not really much we can do here besides documenting that it's recommended and that it'd have to happen on the Docker host, not in the container 😞 |
This isn't a "run a container to solve a problem" kind of thing, but I appreciate there being containers running as part of a stack to help serve as documentation for what's been done to the host. That said, I believe some folks may find https://github.com/bkuhl/redis-overcommit-on-host useful. |
Thanks for the note @bkuhl. Closing since this not something that can be changed by the image, especially since we don't want to have users running the redis container with |
Guys,
There are some official recommended settings here http://redis.io/topics/admin
One should be
RUN sysctl vm.overcommit_memory=1
What do you think?
Thanks
The text was updated successfully, but these errors were encountered: