Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering devfile stacks based on the architecture field in metadata when running odo init #6803

Closed
6 tasks
Tracked by #6669
feloy opened this issue May 9, 2023 · 1 comment · Fixed by #7004
Closed
6 tasks
Tracked by #6669
Assignees
Labels
kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Milestone

Comments

@feloy
Copy link
Contributor

feloy commented May 9, 2023

User Story

  • As an odo user using a cluster running on IBM Z
  • I want odo init Stack selection to list only stacks supporting IBM Z
  • So that I don't create a component that uses devfile that won't work on my cluster.

Parent user-story: #6669

Acceptance Criteria

  • Stacks without any architectures in the index are compatible with all of them

  • odo init interactive mode should ask for architectures (multi-choice) before to ask to select a Devfile stack

  • x86 architecture is checked by default

  • make it work with index and v2index

  • Possibly add human readable architecture names for the user selection

  • On flag mode, add a flag --architecture=x64 --architecture=ppc64le. Default value: amd64 (to be sure it works for amd64 users)
    Get available values at https://github.com/devfile/api/blob/main/pkg/devfile/header.go#L24-L29 to display it on help/output mesg, and error out if passed value not in the list

  • No automatic

  • In Alizer mode, display the architectures supported by the chosen Devfile, so the user can reply No and select manually a new one

registry-library documentation on how to filter based on architecture https://github.com/devfile/registry-support/tree/main/registry-library#specify-registry-options

/kind user-story
/priority high

@openshift-ci openshift-ci bot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels May 9, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label May 9, 2023
@rm3l
Copy link
Member

rm3l commented Jul 6, 2023

Grooming (Jul 6, 2023)

  • List of architectures built using constants from the library
  • Unit tests only

@rm3l rm3l removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Jul 6, 2023
@feloy feloy self-assigned this Jul 25, 2023
@rm3l rm3l added this to the v3.14.0 🚀 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants