Use odo with OpenShift Service Mesh (aka Istio)

[dudash]

[kind/Feature]

Which functionality do you think we should add?

I think it'd be great to have the ability to use odo in conjunction with Istio/OpenShift Service Mesh. Service Mesh requires an annotation on the DeploymentConfigs created for each component. This is in order for the platform to inject a sidecar container with each pod. (spec/template/metadata/annotations of sidecar.istio.io/inject: "true").

See ref docs here:
https://docs.openshift.com/container-platform/4.3/service_mesh/service_mesh_day_two/prepare-to-deploy-applications-ossm.html#ossm-automatic-sidecar-injection_deploying-applications-ossm

Additionally, Services that get created should have port names that follow the naming listed here (for full support of routing and metrics):
https://istio.io/docs/ops/configuration/traffic-management/protocol-selection/
e.g.

  spec:
    ports:
    - port: 8080
      targetPort: 8080
      name: http

Why is this needed?

To allow odo to be used in conjunction with OpenShift Service Mesh

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[dudash]

Can we keep this open? I think it's still important.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[dudash]

/lifecycle frozen

[kadel]

Can we keep this open? I think it's still important.

Yes, sorry about not following up on that.
This is definitely something that we want to get to.
Now we are finishing our transition to using Devfiles as a common format to describe the development environment. We will look into this right after we finish this transition

[faysou]

Being able to use annotations with odo would also be useful for dapr.io which also uses a sidecar.

[kadel]

Devfile API was just updated to allow specifying annotations. (devfile/api#661) Before we can levarege this in odo we still need to wait for github.com/devfile/library to implement it.