Skip to content

Commit

Permalink
feat(PF4 Page): Allow passing of custom ref for condensed header (pat…
Browse files Browse the repository at this point in the history 
…ternfly#941)

* feat(pf4 page): add option to pass in ref functuin

* cleanup

* build

* Update packages/patternfly-4/react-core/src/layouts/Page/Page.js

Co-Authored-By: jschuler <jschuler@redhat.com>

* regenerate snapshots

* upgrade next

* next

* remove alt textinput and update snaps
  • Loading branch information
@jschuler @tlabaj
jschuler authored and tlabaj committed Nov 20, 2018
1 parent 769b67b commit 889ec1a
Show file tree
Hide file tree
Showing 22 changed files with 247 additions and 2,625 deletions.
4 changes: 2 additions & 2 deletions packages/patternfly-4/react-charts/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@
"victory": "^30.1.0"
},
"devDependencies": {
"@patternfly/patternfly-next": "1.0.75",
"@patternfly/patternfly-next": "1.0.78",
"css": "^2.2.3",
"fs-extra": "^6.0.1",
"glob": "^7.1.2",
"npmlog": "^4.1.2"
}
}
}
4 changes: 2 additions & 2 deletions packages/patternfly-4/react-core/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@
"@patternfly/react-tokens": "^1.0.0"
},
"devDependencies": {
"@patternfly/patternfly-next": "1.0.75",
"@patternfly/patternfly-next": "1.0.78",
"css": "^2.2.3",
"fs-extra": "^6.0.1",
"glob": "^7.1.2",
"npmlog": "^4.1.2"
}
}
}
94 changes: 46 additions & 48 deletions packages/patternfly-4/react-core/src/components/Button/__snapshots__/Button.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ exports[`aria-disabled is set to true and tabIndex to -1 if component is not a b
.pf-c-button.pf-m-primary.pf-m-disabled {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #72767b;
background-color: #d1d1d1;
Expand All @@ -36,16 +36,16 @@ exports[`danger button 1`] = `
.pf-c-button.pf-m-danger {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #ffffff;
background-color: #a30000;
Expand All @@ -68,16 +68,16 @@ exports[`isBlock 1`] = `
.pf-c-button.pf-m-primary.pf-m-block {
display: block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
width: 100%;
color: #ffffff;
Expand All @@ -100,16 +100,16 @@ exports[`isDisabled 1`] = `
.pf-c-button.pf-m-primary.pf-m-disabled {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #72767b;
background-color: #d1d1d1;
Expand All @@ -132,16 +132,16 @@ exports[`isFocus 1`] = `
.pf-c-button.pf-m-primary.pf-m-focus {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #ffffff;
background-color: #00659c;
Expand All @@ -163,16 +163,16 @@ exports[`isHover 1`] = `
.pf-c-button.pf-m-primary.pf-m-hover {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #ffffff;
background-color: #00659c;
Expand All @@ -194,19 +194,18 @@ exports[`link button 1`] = `
.pf-c-button.pf-m-link {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 0.25rem 0.25rem 0.25rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #00486e;
background-color: transparent;
}
<button
Expand All @@ -226,19 +225,18 @@ exports[`plain button 1`] = `
.pf-c-button.pf-m-plain {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.5rem 0.5rem 0.5rem 0.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #282d33;
background-color: transparent;
}
<button
Expand All @@ -258,16 +256,16 @@ exports[`primary button 1`] = `
.pf-c-button.pf-m-primary {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #ffffff;
background-color: #00659c;
Expand All @@ -290,18 +288,18 @@ exports[`secondary button 1`] = `
.pf-c-button.pf-m-secondary {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #00659c;
color: #007bba;
background-color: transparent;
}
Expand All @@ -322,16 +320,16 @@ exports[`tertiary button 1`] = `
.pf-c-button.pf-m-tertiary {
display: inline-block;
position: relative;
min-width: 44px;
min-height: 44px;
padding: 0.25rem 1.5rem 0.25rem 1.5rem;
min-width: undefined;
min-height: undefined;
padding: 0.375rem 1rem 0.375rem 1rem;
font-size: 1rem;
font-weight: 500;
line-height: 1.5;
text-align: center;
white-space: nowrap;
border: 0px;
border-radius: 30em;
border-radius: 3px;
text-decoration: none;
color: #282d33;
background-color: transparent;
Expand Down
8 changes: 4 additions & 4 deletions packages/patternfly-4/react-core/src/components/Form/__snapshots__/FormGroup.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ exports[`FormGroup component should render form group invalid variant 1`] = `
`;

exports[`FormGroup component should render form group required variant 1`] = `
.pf-c-form__label__required {
.pf-c-form__label-required {
display: block;
}
.pf-c-form__label {
Expand Down Expand Up @@ -155,7 +155,7 @@ exports[`FormGroup component should render form group required variant 1`] = `
label
<span
aria-hidden="true"
className="pf-c-form__label__required"
className="pf-c-form__label-required"
>
*
</span>
Expand Down Expand Up @@ -338,7 +338,7 @@ exports[`FormGroup component should render form group variant with node label 1`
`;

exports[`FormGroup component should render form group variant with required label 1`] = `
.pf-c-form__label__required {
.pf-c-form__label-required {
display: block;
}
.pf-c-form__label {
Expand Down Expand Up @@ -366,7 +366,7 @@ exports[`FormGroup component should render form group variant with required labe
label
<span
aria-hidden="true"
className="pf-c-form__label__required"
className="pf-c-form__label-required"
>
*
</span>
Expand Down
6 changes: 0 additions & 6 deletions ...ges/patternfly-4/react-core/src/components/LoginPage/__snapshots__/LoginForm.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ exports[`LoginForm with rememberMeLabel and no rememberMeAriaLabel generates con
aria-label={null}
className=""
id="pf-login-username-id"
isAlt={false}
isDisabled={false}
isReadOnly={false}
isRequired={true}
Expand All @@ -64,7 +63,6 @@ exports[`LoginForm with rememberMeLabel and no rememberMeAriaLabel generates con
aria-label={null}
className=""
id="pf-login-password-id"
isAlt={false}
isDisabled={false}
isReadOnly={false}
isRequired={true}
Expand Down Expand Up @@ -151,7 +149,6 @@ exports[`LoginForm with rememberMeLabel and rememberMeAriaLabel does not generat
aria-label={null}
className=""
id="pf-login-username-id"
isAlt={false}
isDisabled={false}
isReadOnly={false}
isRequired={true}
Expand All @@ -176,7 +173,6 @@ exports[`LoginForm with rememberMeLabel and rememberMeAriaLabel does not generat
aria-label={null}
className=""
id="pf-login-password-id"
isAlt={false}
isDisabled={false}
isReadOnly={false}
isRequired={true}
Expand Down Expand Up @@ -258,7 +254,6 @@ exports[`should render Login form 1`] = `
aria-label={null}
className=""
id="pf-login-username-id"
isAlt={false}
isDisabled={false}
isReadOnly={false}
isRequired={true}
Expand All @@ -283,7 +278,6 @@ exports[`should render Login form 1`] = `
aria-label={null}
className=""
id="pf-login-password-id"
isAlt={false}
isDisabled={false}
isReadOnly={false}
isRequired={true}
Expand Down
Loading

0 comments on commit 889ec1a

Please sign in to comment.