fix(dropdown): Address typescript errors (patternfly#898)

This fixes the various typescript errors encountered while the Dropdown component in the Koku UI Fixes patternfly#892
redallen · Nov 7, 2018 · 48a3256 · 48a3256
1 parent fdc3286
commit 48a3256
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/patternfly-4/react-core/src/components/Dropdown/Dropdown.d.ts b/packages/patternfly-4/react-core/src/components/Dropdown/Dropdown.d.ts
@@ -1,15 +1,17 @@
 import { SFC, HTMLProps, ReactType, ReactNode } from 'react';
 import { OneOf } from '../../typeUtils';
-import { DropdownToggleProps } from './DropdownToggle';
+import DropdownToggle from './DropdownToggle';
 import { DropdownPosition, DropdownDirection } from './dropdownConstants';
 
 export interface DropdownProps extends HTMLProps<HTMLDivElement> {
   children?: ReactNode;
-  isOpen?: Boolean;
-  isAction?: Boolean;
+  dropdownItems: ReactNode[];
+  isOpen?: boolean;
+  isAction?: boolean;
+  onSelect?: Function;
   position?: OneOf<typeof DropdownPosition, keyof typeof DropdownPosition>;
   direction?: OneOf<typeof DropdownDirection, keyof typeof DropdownDirection>;
-  toggle?: DropdownToggleProps;
+  toggle?: DropdownToggle;
 }
 
 declare const Dropdown: SFC<DropdownProps>;

diff --git a/packages/patternfly-4/react-core/src/components/Dropdown/DropdownToggle.d.ts b/packages/patternfly-4/react-core/src/components/Dropdown/DropdownToggle.d.ts
@@ -3,9 +3,9 @@ import { SFC, HTMLProps, ReactType, ReactNode } from 'react';
 export interface DropdownToggleProps extends HTMLProps<HTMLButtonElement> {
   id?: string;
   children?: ReactNode;
-  isOpen?: Boolean;
+  isOpen?: boolean;
   onToggle?: Function;
-  parentRef: HTMLElement;
+  parentRef?: HTMLElement;
   isFocused?: boolean;
   isHovered?: boolean;
   isActive?: boolean;