fix(ModelessOverlay): Fix for animation on open in Firefox browser (p…

…atternfly#776) Use a 150ms delay to update show & in classes for both open and close fixes patternfly#774
redallen · Oct 17, 2018 · 469ab3a · 469ab3a
1 parent f47af0b
commit 469ab3a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/patternfly-3/patternfly-react/src/components/ModelessOverlay/ModelessOverlay.js b/packages/patternfly-3/patternfly-react/src/components/ModelessOverlay/ModelessOverlay.js
@@ -8,7 +8,7 @@ class ModelessOverlay extends React.Component {
   constructor(props) {
     super(props);
     this.state = { isIn: false };
-    this.inTimer = new Timer(null, 150);
+    this.inTimer = new Timer(this.updateForTransitions, 150);
   }
 
   componentWillUnmount() {
@@ -30,7 +30,8 @@ class ModelessOverlay extends React.Component {
     );
 
     if (isIn !== show) {
-      this.inTimer.startTimer(() => this.updateForTransitions(), show ? 0 : 150);
+      this.inTimer.clearTimer();
+      this.inTimer.startTimer();
     }
 
     const dialogClasses = classNames('modal-dialog', {