fix(Dropdown): Do not focus Dropdown if menu is not opened (patternfl…

…y#1222)
redallen · Jan 21, 2019 · 45367bc · 45367bc
1 parent 1a6d3e1
commit 45367bc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/patternfly-4/react-core/src/components/Dropdown/Toggle.js b/packages/patternfly-4/react-core/src/components/Dropdown/Toggle.js
@@ -55,7 +55,7 @@ class DropdownToggle extends Component {
   };
 
   onDocClick = event => {
-    if (this.props.parentRef && !this.props.parentRef.contains(event.target)) {
+    if (this.props.isOpen && this.props.parentRef && !this.props.parentRef.contains(event.target)) {
       this.props.onToggle && this.props.onToggle(false);
       this.toggle.focus();
     }
@@ -64,7 +64,7 @@ class DropdownToggle extends Component {
   onEscPress = event => {
     const { parentRef } = this.props;
     const keyCode = event.keyCode || event.which;
-    if ((keyCode === KEY_CODES.ESCAPE_KEY || event.key === 'Tab') && parentRef && parentRef.contains(event.target)) {
+    if (this.props.isOpen && (keyCode === KEY_CODES.ESCAPE_KEY || event.key === 'Tab') && parentRef && parentRef.contains(event.target)) {
       this.props.onToggle && this.props.onToggle(false);
       this.toggle.focus();
     }