Skip to content

Commit

Permalink
fix(patternfly-4/react-core): Make the id prop for Dropdown optional …
Browse files Browse the repository at this point in the history
…in d.ts file (patternfly#841)

patternfly#840
  • Loading branch information
tlabaj authored and jschuler committed Oct 29, 2018
1 parent e40f35f commit 3bac80e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class Dropdown extends React.Component {
position,
...props
} = this.props;
const id = toggle.props.id || `pf-toggel-id-${currentId++}`;
const id = toggle.props.id || `pf-toggle-id-${currentId++}`;
let component;
let renderedContent;
if (dropdownItems && dropdownItems.length > 0) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { SFC, HTMLProps, ReactType, ReactNode } from 'react';

export interface DropdownToggleProps extends HTMLProps<HTMLButtonElement> {
id: string;
id?: string;
children?: ReactNode;
isOpen?: Boolean;
onToggle?: Function;
Expand Down

0 comments on commit 3bac80e

Please sign in to comment.