fix(LoginPage): Fix background-image style (patternfly#937)

redallen · Nov 19, 2018 · 3307e9b · 3307e9b
1 parent 793bbe7
commit 3307e9b
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/packages/patternfly-3/patternfly-react/src/components/LoginPage/LoginPage.test.js b/packages/patternfly-3/patternfly-react/src/components/LoginPage/LoginPage.test.js
@@ -14,6 +14,7 @@ const createProps = () => {
   const { header, card } = englishMessages;
   return {
     container: {
+      backgroundUrl: '/some-background',
       translations: { en: englishMessages, fr: frenchMessages },
       alert: {
         message: header.alert,

diff --git a/packages/patternfly-3/patternfly-react/src/components/LoginPage/SocialLoginPage.test.js b/packages/patternfly-3/patternfly-react/src/components/LoginPage/SocialLoginPage.test.js
@@ -71,6 +71,7 @@ const createProps = () => {
   const { header, footerLinks, card } = englishMessages;
   return {
     container: {
+      backgroundUrl: '/some-background',
       translations: { en: englishMessages, fr: frenchMessages },
       className: '',
       alert: {

diff --git a/...tternfly-3/patternfly-react/src/components/LoginPage/__snapshots__/LoginPage.test.js.snap b/...tternfly-3/patternfly-react/src/components/LoginPage/__snapshots__/LoginPage.test.js.snap
@@ -3,7 +3,7 @@
 exports[`Component matches snapshot 1`] = `
 <div
   class="login-pf"
-  style="background-image: url(null);"
+  style="background-image: url(/some-background);"
 >
   <div
     class="login-pf-page "

diff --git a/...ly-3/patternfly-react/src/components/LoginPage/__snapshots__/SocialLoginPage.test.js.snap b/...ly-3/patternfly-react/src/components/LoginPage/__snapshots__/SocialLoginPage.test.js.snap
@@ -3,7 +3,7 @@
 exports[`Component matches snapshot 1`] = `
 <div
   class="login-pf"
-  style="background-image: url(null);"
+  style="background-image: url(/some-background);"
 >
   <div
     class="login-pf-page  login-pf-page-accounts"

diff --git a/...rnfly-react/src/components/LoginPage/components/LoginPageComponents/LoginPageContainer.js b/...rnfly-react/src/components/LoginPage/components/LoginPageComponents/LoginPageContainer.js
@@ -2,9 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 const LoginPageContainer = ({ backgroundUrl, className, children }) => {
-  const style = {
-    backgroundImage: `url(${backgroundUrl})`
-  };
+  const style = backgroundUrl ? { backgroundImage: `url(${backgroundUrl})` } : {};
 
   return (
     <div className="login-pf" style={style}>