[PHP 8.1] Add null to string in Function Call Arg: NullToStrictStringFuncCallArgRector

[samsonasik]

Feature Request

There are function calls that previously allow null to be need as string, eg: preg_split, ref ref https://3v4l.org/lbPsJ

preg_split("#a#", null);

Another use case is preg_match, ref https://3v4l.org/WQ1Pk

preg_match('/(foo)(bar)(baz)/', null, $matches);

that will error on php 8.1

I think we need to have general FuncCall Rector for it, eg: NullToStrictStringFuncCallArgRector that can have collection of function call with args that need to be string.

[samsonasik]

Another function to have strict string arg in php 8.1, preg_match_all ref https://3v4l.org/AFWHB

[samsonasik]

Also on explode function https://3v4l.org/3FsLf

[samsonasik]

strlen as well https://3v4l.org/0s1Gs

[tigitz]

@samsonasik Not sure if it should be taken into account in this rector since the naming specifies StrictString but here are more functions where nullability has been deprecated:

• number_format https://3v4l.org/Is3gj
• strtotime https://3v4l.org/V7c88

[samsonasik]

@tigitz could you add PR to add that on https://github.com/rectorphp/rector-src/blob/77a4582d5044446b8da43ab91a09082fa0413a23/rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php#L48 ? Also better to have a fixture updated for it at https://github.com/rectorphp/rector-src/tree/main/rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture

[FlorinProfeanu]

Are there news about managing strtotime (on other similar functions)?

[samsonasik]

Feel free to create PR to register more functions into the list of it at https://github.com/rectorphp/rector-src/blob/992d1efc7596864c960b3a9837ebf8ee04eb159d/rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php#L42-L49