Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rector-prefixed - File not found running dead-code set #3710

Closed
plasticlobster opened this issue Jul 14, 2020 · 9 comments
Closed

rector-prefixed - File not found running dead-code set #3710

plasticlobster opened this issue Jul 14, 2020 · 9 comments
Assignees

Comments

@plasticlobster
Copy link

Bug Report

Subject Details
Rector version v0.7.48
Installed as prefixed Rector PHAR

In the refactoring stage, it throws the error:

In SmartFileInfo.php line 22:
  [Symplify\SmartFileSystem\Exception\FileNotFoundException]                                                                                                                                                            
  File path "phar:///REDACTED/vendor/rector/rector-prefixed/rector/rules/dead-code/src/Rector/FunctionLike/RemoveDuplicatedIfReturnRector.php" was not found while creating "Symplify\SmartFileSystem\SmartFileInfo" object.   

This crashes Rector, and it does not continue.

Minimal PHP Code Causing Issue

This is not related to PHP code. This is after the parsing step is complete and appears to be a build issue with the phar.

Expected Behaviour

Files shouldn't be missing from the prefixed build, and it should continue refactoring

@bellwood
Copy link

@TomasVotruba
Copy link
Member

What version is that?

@bellwood
Copy link

./rector.phar --version states Rector 0.8.x-dev@ae3adef

I snagged the version from 2 days ago before the current commits failed testing.

I just ran it against a PHP 5.4 procedural project to jump from MySQL to MySQLi and had no issues.

@TomasVotruba
Copy link
Member

Thanks!

Here is a diff of changes since that commit to current master: ae3adef...master

@bellwood
Copy link

Sure thing, thanks for this project!

@TomasVotruba
Copy link
Member

Related box-project/box#470

@TomasVotruba
Copy link
Member

Related CI failing: https://github.com/rectorphp/rector-prefixed

@TomasVotruba
Copy link
Member

I just released version with few fixes or phar.

Could you confirm the same bug still persist or is there some new error?

@TomasVotruba TomasVotruba self-assigned this Jul 20, 2020
@TomasVotruba
Copy link
Member

TomasVotruba commented Jul 21, 2020

This issue should be resolved on rector-prefixed, CI is passing for set run.

Fails for different reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants