rector-prefixed breaks use statements and triggers errors

[gnutix]

Bug Report

Subject	Details
Rector version	since 1b052ca
Installed as	prefixed Rector PHAR

It's been quite some time I haven't updated Rector on our project. Today I decided to do so and noticed some issues, so I went back in time (downloading previous versions of rector-prefixed's phar) until I had a working one. Here's the history :

1. Updated Rector to commit d0a2b47 : works ! 👍
2. Updated Rector to commit 1b052ca broken with [ERROR] The file "../utils" does not exist (in: phar:///app/rector.phar/src/HttpKernel/../../config)..
3. Updated Rector to commit 6547a65 broken with Warning: require(phar:///app/rector.phar/vendor/composer/../../helpers/rector_dump_function.php): failed to open stream: phar error: "helpers/rector_dump_function.php" is not a file in phar "/app/rector.phar" in phar:///app/rector.phar/vendor/composer/autoload_real.php on line 57
4. Updated Rector to commit 768b94d +
   Updated Rector to commit 02ac09f +
   Updated Rector to commit 0e46944 broken with [ERROR] The file "../utils" does not exist (in: phar:///app/rector.phar/src/HttpKernel/../../config).
5. Updated Rector to commit 7e0bf17 and all versions up to HEAD broken with :

 [ERROR] Could not process "src/Some/File.php" file,   
         due to:                                                                                                        
         "Class '_HumbugBox551e43838180\JetBrains\PHPStormStub\PhpStormStubsMap' not found".                            

And all "use" statements are broken like this :

<?php
-use DataURI\Data;
-use DataURI\Dumper;
-use PHPUnit\Framework\TestCase;
-use Symfony\Component\Filesystem\Filesystem;
-use Webmozart\Assert\Assert;
-
+use Data;
+use Dumper;
+use TestCase;
+use Filesystem;
+use Assert;

6. Updated Rector to commit HEAD also has the following extra error :

 [ERROR] Could not process "src/Some/File.php" file by                      
         "Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector", due to:                                       
         "Call to a member function changeVarType() on null".                                                           

Any idea what changes might have triggered all this ?

[TomasVotruba]

Failing CI would be much better 👍

[gnutix]

Any idea what changes might have triggered all this ?

Means I have absolutely no idea what might be broken, nor why, so making CI fail is not undoable for me right now... I did the most I could, providing a "git bisect" equivalent on the commits.

[TomasVotruba]

Closing as duplicated of #2879

[gnutix]

This is not exactly a duplicate of #2879... There's two extra errors in here that are not listed in that issue :

1. the broken use statements
2. "Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector", due to "Call to a member function changeVarType() on null"

The first might be related to the stubs (maybe?), but I doubt the second would be.

[TomasVotruba]

Do not mix 2 issues at once. please re-open with new ones. Also, do not re-open issues, or I'll have to decrease your access. it's really frustrating to organize Rector issues with you doing it.

Demo link for this is needed.