From d4a432e7e490695a11daa32bce6bf20ab0d075f6 Mon Sep 17 00:00:00 2001
From: Markus Staab <markus.staab@redaxo.de>
Date: Wed, 12 Jul 2023 09:58:44 +0200
Subject: [PATCH] Fix StrictArrayParamDimFetchRector on `is_*` calls (#4486)

* StrictArrayParamDimFetchRector failing test

* Rename string_array_union.php.inc to skip_string_array_union.php.inc

* more failling tests

* fix

* fix

* Update StrictArrayParamDimFetchRector.php
---
 .../Fixture/skip_is_bool.php.inc              | 20 +++++++++++++++++++
 .../Fixture/skip_is_float.php.inc             | 20 +++++++++++++++++++
 .../Fixture/skip_is_int.php.inc               | 20 +++++++++++++++++++
 .../Fixture/skip_is_string.php.inc            | 20 +++++++++++++++++++
 .../StrictArrayParamDimFetchRector.php        |  2 +-
 5 files changed, 81 insertions(+), 1 deletion(-)
 create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_bool.php.inc
 create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_float.php.inc
 create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_int.php.inc
 create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_string.php.inc

diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_bool.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_bool.php.inc
new file mode 100644
index 00000000000..aed2e1e3b06
--- /dev/null
+++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_bool.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class SkipIsBool
+{
+    private function getLabelsForIds($ids)
+    {
+        if (is_bool($ids)) {
+            $ids = explode(',', $ids);
+        }
+        if (! isset($ids[0])) {
+            return '';
+        }
+
+        if ('alle' === $ids[0]) {
+            return $ids[0];
+        }
+    }
+}
diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_float.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_float.php.inc
new file mode 100644
index 00000000000..cbbd9dda259
--- /dev/null
+++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_float.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class SkipIsFloat
+{
+    private function getLabelsForIds($ids)
+    {
+        if (is_float($ids)) {
+            $ids = explode(',', $ids);
+        }
+        if (! isset($ids[0])) {
+            return '';
+        }
+
+        if ('alle' === $ids[0]) {
+            return $ids[0];
+        }
+    }
+}
diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_int.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_int.php.inc
new file mode 100644
index 00000000000..0f8809c2edf
--- /dev/null
+++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_int.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class SkipIsInt
+{
+    private function getLabelsForIds($ids)
+    {
+        if (is_int($ids)) {
+            $ids = explode(',', $ids);
+        }
+        if (! isset($ids[0])) {
+            return '';
+        }
+
+        if ('alle' === $ids[0]) {
+            return $ids[0];
+        }
+    }
+}
diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_string.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_string.php.inc
new file mode 100644
index 00000000000..9e95c0b54c8
--- /dev/null
+++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_is_string.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class SkipIsString
+{
+    private function getLabelsForIds($ids)
+    {
+        if (is_string($ids)) {
+            $ids = explode(',', $ids);
+        }
+        if (! isset($ids[0])) {
+            return '';
+        }
+
+        if ('alle' === $ids[0]) {
+            return $ids[0];
+        }
+    }
+}
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php b/rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php
index 17c57860881..5675a66f498 100644
--- a/rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php
+++ b/rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php
@@ -104,7 +104,7 @@ private function isParamAccessedArrayDimFetch(Param $param, ClassMethod|Function
             $paramName,
             &$isParamAccessedArrayDimFetch
         ): int|null {
-            if ($node instanceof FuncCall && $this->isName($node, 'is_array')) {
+            if ($node instanceof FuncCall && $this->isNames($node, ['is_array', 'is_string', 'is_int', 'is_bool', 'is_float'])) {
                 $firstArg = $node->getArgs()[0];
                 if ($this->isName($firstArg->value, $paramName)) {
                     return NodeTraverser::STOP_TRAVERSAL;