From 160034e80f2ff7def66a47fa5531bc2cf7148812 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Thu, 2 Jun 2022 09:33:22 +0200
Subject: [PATCH] prepare parameter update

---
 .../PhpDocParser/BetterPhpDocParser.php       |  4 +-
 .../ConstExprClassNameDecorator.php           | 65 +++++++++++++++++++
 .../Fixture/change_param_type.php.inc         | 33 ++++++++++
 .../Source/Gear.php                           | 12 ++++
 .../Class_/ConstantListClassToEnumRector.php  | 64 ++++++++++++++++--
 5 files changed, 172 insertions(+), 6 deletions(-)
 create mode 100644 packages/BetterPhpDocParser/PhpDocParser/ConstExprClassNameDecorator.php
 create mode 100644 rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Fixture/change_param_type.php.inc
 create mode 100644 rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Source/Gear.php

diff --git a/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php b/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php
index 461427e2266..c00cb82e40f 100644
--- a/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php
+++ b/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php
@@ -32,7 +32,8 @@ public function __construct(
         TypeParser $typeParser,
         ConstExprParser $constExprParser,
         private readonly TokenIteratorFactory $tokenIteratorFactory,
-        private readonly DoctrineAnnotationDecorator $doctrineAnnotationDecorator
+        private readonly DoctrineAnnotationDecorator $doctrineAnnotationDecorator,
+        private readonly ConstExprClassNameDecorator $constExprClassNameDecorator,
     ) {
         parent::__construct($typeParser, $constExprParser);
 
@@ -61,6 +62,7 @@ public function parse(TokenIterator $tokenIterator): PhpDocNode
         $phpDocNode = new PhpDocNode($children);
         // replace generic nodes with DoctrineAnnotations
         $this->doctrineAnnotationDecorator->decorate($phpDocNode);
+        $this->constExprClassNameDecorator->decorate($phpDocNode);
 
         return $phpDocNode;
     }
diff --git a/packages/BetterPhpDocParser/PhpDocParser/ConstExprClassNameDecorator.php b/packages/BetterPhpDocParser/PhpDocParser/ConstExprClassNameDecorator.php
new file mode 100644
index 00000000000..61585f00704
--- /dev/null
+++ b/packages/BetterPhpDocParser/PhpDocParser/ConstExprClassNameDecorator.php
@@ -0,0 +1,65 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\BetterPhpDocParser\PhpDocParser;
+
+use PhpParser\Node as PhpNode;
+use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprNode;
+use PHPStan\PhpDocParser\Ast\ConstExpr\ConstFetchNode;
+use PHPStan\PhpDocParser\Ast\Node;
+use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode;
+use Rector\BetterPhpDocParser\ValueObject\PhpDocAttributeKey;
+use Rector\Core\Configuration\CurrentNodeProvider;
+use Rector\Core\Exception\ShouldNotHappenException;
+use Rector\StaticTypeMapper\Naming\NameScopeFactory;
+use Symplify\Astral\PhpDocParser\PhpDocNodeTraverser;
+
+/**
+ * Decorate node with fully qualified class name for const epxr,
+ * e.g. Direction::*
+ */
+final class ConstExprClassNameDecorator
+{
+    public function __construct(
+        private CurrentNodeProvider $currentNodeProvider,
+        private NameScopeFactory $nameScopeFactory,
+        private PhpDocNodeTraverser $phpDocNodeTraverser
+    ) {
+    }
+
+    public function decorate(PhpDocNode $phpDocNode): void
+    {
+        $phpNode = $this->currentNodeProvider->getNode();
+
+        if (! $phpNode instanceof PhpNode) {
+            throw new ShouldNotHappenException();
+        }
+
+        $this->phpDocNodeTraverser->traverseWithCallable($phpDocNode, '', function (Node $node) use (
+            $phpNode
+        ): int|Node|null {
+            if (! $node instanceof ConstExprNode) {
+                return null;
+            }
+
+            $className = $this->resolveFullyQualifiedClass($node, $phpNode);
+            if ($className === null) {
+                return null;
+            }
+
+            $node->setAttribute(PhpDocAttributeKey::RESOLVED_CLASS, $className);
+            return $node;
+        });
+    }
+
+    private function resolveFullyQualifiedClass(ConstExprNode $constExprNode, PhpNode $node): ?string
+    {
+        if (! $constExprNode instanceof ConstFetchNode) {
+            return null;
+        }
+
+        $nameScope = $this->nameScopeFactory->createNameScopeFromNodeWithoutTemplateTypes($node);
+        return $nameScope->resolveStringName($constExprNode->className);
+    }
+}
diff --git a/rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Fixture/change_param_type.php.inc b/rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Fixture/change_param_type.php.inc
new file mode 100644
index 00000000000..33669e3c40f
--- /dev/null
+++ b/rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Fixture/change_param_type.php.inc
@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\ConstantListClassToEnumRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Class_\ConstantListClassToEnumRector\Source\Gear;
+
+final class ChangeParamType
+{
+    /**
+     * @param Gear::* $gear
+     */
+    public function changeGear(string $gear)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\ConstantListClassToEnumRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Class_\ConstantListClassToEnumRector\Source\Gear;
+
+final class ChangeParamType
+{
+    public function changeGear(Gear $gear)
+    {
+    }
+}
+
+?>
+
diff --git a/rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Source/Gear.php b/rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Source/Gear.php
new file mode 100644
index 00000000000..37609b29c0f
--- /dev/null
+++ b/rules-tests/Php80/Rector/Class_/ConstantListClassToEnumRector/Source/Gear.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php80\Rector\Class_\ConstantListClassToEnumRector\Source;
+
+final class Gear
+{
+    public const FIRST = 'first';
+
+    public const SECOND = 'second';
+}
diff --git a/rules/Php80/Rector/Class_/ConstantListClassToEnumRector.php b/rules/Php80/Rector/Class_/ConstantListClassToEnumRector.php
index 5d9a7fb2076..2235e2555e4 100644
--- a/rules/Php80/Rector/Class_/ConstantListClassToEnumRector.php
+++ b/rules/Php80/Rector/Class_/ConstantListClassToEnumRector.php
@@ -6,7 +6,16 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\ClassMethod;
+use PHPStan\PhpDocParser\Ast\ConstExpr\ConstFetchNode;
+use PHPStan\PhpDocParser\Ast\Type\ConstTypeNode;
+use PHPStan\Reflection\ParametersAcceptorSelector;
+use PHPStan\Reflection\Php\PhpParameterReflection;
+use PHPStan\Type\UnionType;
+use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
+use Rector\BetterPhpDocParser\ValueObject\PhpDocAttributeKey;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Php80\NodeAnalyzer\EnumConstListClassDetector;
 use Rector\Php81\NodeFactory\EnumFactory;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -19,7 +28,8 @@ final class ConstantListClassToEnumRector extends AbstractRector
 {
     public function __construct(
         private readonly EnumConstListClassDetector $enumConstListClassDetector,
-        private readonly EnumFactory $enumFactory
+        private readonly EnumFactory $enumFactory,
+        private readonly ReflectionResolver $reflectionResolver,
     ) {
     }
 
@@ -54,18 +64,62 @@ enum Direction
      */
     public function getNodeTypes(): array
     {
-        return [Class_::class];
+        return [Class_::class, ClassMethod::class];
     }
 
     /**
-     * @param Class_ $node
+     * @param Class_|ClassMethod $node
      */
     public function refactor(Node $node): ?Node
     {
-        if (! $this->enumConstListClassDetector->detect($node)) {
+        if ($node instanceof Class_) {
+            if (! $this->enumConstListClassDetector->detect($node)) {
+                return null;
+            }
+
+            return $this->enumFactory->createFromClass($node);
+        }
+
+        return $this->refactorClassMethod($node);
+    }
+
+    private function refactorClassMethod(ClassMethod $classMethod): ?ClassMethod
+    {
+        if ($classMethod->params === []) {
+            return null;
+        }
+
+        // enum param types doc requires a docblock
+        $phpDocInfo = $this->phpDocInfoFactory->createFromNode($classMethod);
+        if (! $phpDocInfo instanceof PhpDocInfo) {
             return null;
         }
 
-        return $this->enumFactory->createFromClass($node);
+        $methodReflection = $this->reflectionResolver->resolveMethodReflectionFromClassMethod($classMethod);
+
+        $parametersAcceptor = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants());
+        foreach ($parametersAcceptor->getParameters() as $parameterReflection) {
+            if (! $parameterReflection instanceof PhpParameterReflection) {
+                continue;
+            }
+
+            // should be union, that is how PHPStan resolves it
+            if (! $parameterReflection->getType() instanceof UnionType) {
+                continue;
+            }
+
+            $paramTagValueNode = $phpDocInfo->getParamTagValueByName($parameterReflection->getName());
+            if ($paramTagValueNode->type instanceof ConstTypeNode) {
+                $constTypeNode = $paramTagValueNode->type;
+                if ($constTypeNode->constExpr instanceof ConstFetchNode) {
+                    $constExpr = $constTypeNode->constExpr;
+                    dump($constExpr->getAttribute(PhpDocAttributeKey::RESOLVED_CLASS));
+                    dump('___');
+                    die;
+                }
+            }
+        }
+
+        return null;
     }
 }