Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow changing of units of measurement in recipes when changing servings #449

Open
mavanmanen opened this issue Oct 21, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request go Pull requests that update Go code
Milestone

Comments

@mavanmanen
Copy link

mavanmanen commented Oct 21, 2024

Currently when you change the servings for a recipe it will change the units for ingredients.
As an example: 960 ml of chicken stock for 8 servings becomes 4 4/5 dl for 4 servings instead of 480 ml.
Not only is the usage of fractions like 4/5 uncommon in the metric system and it should have translated to 4.8 dl, it is also much more preferable to keep using the original unit as put into the recipe.
Same should apply to other notations, 0.25 should not be changed to 1/4 and vice versa.

@mavanmanen mavanmanen added the enhancement New feature or request label Oct 21, 2024
@reaper47 reaper47 added the go Pull requests that update Go code label Oct 22, 2024
@reaper47 reaper47 added this to Recipya Oct 22, 2024
@reaper47 reaper47 added this to the v1.3.0 milestone Oct 22, 2024
@reaper47 reaper47 self-assigned this Dec 28, 2024
@reaper47 reaper47 moved this to In Progress in Recipya Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants