Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Non-Github projects? #314

Closed
jeeftor opened this issue Oct 7, 2015 · 6 comments
Closed

Support for Non-Github projects? #314

jeeftor opened this issue Oct 7, 2015 · 6 comments

Comments

@jeeftor
Copy link

jeeftor commented Oct 7, 2015

Any chance we could have an "any-url" support here? For say Atlassian Stash or BitBucket? We run stash and gitlab internally at my office.

-g, --github_url URL             GitHub URL of this project (i.e. \
            https://github.com/realm/realm-cocoa)
    --github-file-prefix PREFIX  GitHub URL file prefix of this project (i.e. \
            https://github.com/realm/realm-cocoa/tree/v0.87.1)
@jpsim
Copy link
Collaborator

jpsim commented Oct 7, 2015

You could pass in --github_url and --github-file-prefix along with custom templates that can display whatever you want instead of "View on GitHub" and the little octicon glyph.

@jeeftor
Copy link
Author

jeeftor commented Oct 8, 2015

I created a pull request for this guy! 👍

#315

@istx25 istx25 self-assigned this Nov 23, 2016
@istx25
Copy link
Contributor

istx25 commented Nov 23, 2016

I'll try to get around to reviewing #315. Seems to still be open.

@arueda
Copy link

arueda commented Feb 11, 2019

I see that PR #315 was closed. Is supporting projects outside github without using custom templates still a goal?

@jpsim
Copy link
Collaborator

jpsim commented Feb 12, 2019

Is supporting projects outside github without using custom templates still a goal?

Yeah, that'd be great! I shared my thoughts a few years ago in that PR's thread:

Taking a step back though, I think we can generalize things quite a bit by making the following changes:

  1. --github_url -> --project-url
  2. --github-file-prefix -> --source-host-prefix
  3. --source-host with github, bitbucket & gitlab as options which would affect the "View on GitHub" in the header and "Show on GitHub" link in the declaration description

@johnfairh
Copy link
Collaborator

Addressed in master via #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants