Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extraneous whitespace between attribute name and '('; #5667

Open
ConfusedVorlon opened this issue Jul 12, 2024 · 1 comment · May be fixed by #5669
Open

Extraneous whitespace between attribute name and '('; #5667

ConfusedVorlon opened this issue Jul 12, 2024 · 1 comment · May be fixed by #5669
Labels
good first issue Issue to be taken up by new contributors yet unfamiliar with the project. rule-request Requests for a new rules.

Comments

@ConfusedVorlon
Copy link

New Issue Checklist

New rule request

the following code

private (set) var type: ClipType = .undetermined

generates a warning in Xcode 16 beta 3

warning: extraneous whitespace between attribute name and '('; this is an error in the Swift 6 language mode

  1. Why should this rule be added? Share links to existing discussion about what
    the community thinks about this.
    I assume swiftlint could detect and fix this before Xcode needs to worry about it

  2. Provide several examples of what would and wouldn't trigger violations.

triggers:
private (set) var type: ClipType = .undetermined

doesn't trigger
private(set) var type: ClipType = .undetermined

  1. Should the rule be configurable, if so what parameters should be configurable?
    no

  2. Should the rule be opt-in or enabled by default? Why?
    default - because if swiftlint doesn't handle it, Xcode will
@SimplyDanny SimplyDanny added good first issue Issue to be taken up by new contributors yet unfamiliar with the project. rule-request Requests for a new rules. labels Jul 12, 2024
@SimplyDanny
Copy link
Collaborator

This should be a pretty simple rule to implement. However, it's probably also not a big deal to fix this only as soon as the Swift 6 compiler complains.

@aryamansharda aryamansharda linked a pull request Jul 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue to be taken up by new contributors yet unfamiliar with the project. rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new attribute_name_spacing rule aryamansharda/SwiftLint
2 participants
@ConfusedVorlon @SimplyDanny