Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim public API for 1.0.0 #479

Closed
scottrhoyt opened this issue Feb 3, 2016 · 3 comments
Closed

Trim public API for 1.0.0 #479

scottrhoyt opened this issue Feb 3, 2016 · 3 comments
Labels
discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. wontfix Issues that became stale and were auto-closed by a bot.
Milestone
1.0.0

Comments

@scottrhoyt
Copy link
Contributor

As we get closed to 1.0.0, we should decide what should be available in the public API for SwiftLintFramework. It would be fairly straightforward to to simply trim it to what is necessary for swiftlint and SwiftLintFrameworkTests, but we should discuss and perhaps consider @testable imports for SwiftLintFrameworkTests to reduce the surface area of the public API.
@scottrhoyt scottrhoyt added the discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. label Feb 3, 2016
@scottrhoyt scottrhoyt added this to the 1.0.0 milestone Feb 3, 2016
@jpsim
Copy link
Collaborator

jpsim commented Feb 3, 2016

👍

@jpsim jpsim mentioned this issue Feb 7, 2016
Merged
2 tasks
@norio-nomura
Copy link
Collaborator

I can't imagine which APIs are actually needed to be public without another client of SwiftLintFramework.

@marcelofabri marcelofabri mentioned this issue Dec 31, 2016
Closed
@stale
Copy link

stale bot commented Nov 8, 2020

This issue has been automatically marked as stale because it has not had any recent activity. Please comment to prevent this issue from being closed. Thank you for your contributions!

@stale stale bot added the wontfix Issues that became stale and were auto-closed by a bot. label Nov 8, 2020
@stale stale bot closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. wontfix Issues that became stale and were auto-closed by a bot.
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@norio-nomura @jpsim @scottrhoyt