Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to have CyclomaticComplexityRule ignore case statements? #1298

Closed
mlwelles opened this issue Feb 9, 2017 · 1 comment
Closed

Option to have CyclomaticComplexityRule ignore case statements? #1298

mlwelles opened this issue Feb 9, 2017 · 1 comment
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@mlwelles
Copy link
Contributor

mlwelles commented Feb 9, 2017 •
edited
Loading

I've had a couple of instances where pull requests from my team have include dispatch functions that handle every case in an enum trigger cyclomatic complexity warnings / errors. We've all looked over the code, and agree we like it.

So that we don't trigger with examples we made some changes to have the rule optionally disregard case statements in scoring. I've got a PR ready, will submit if there's any interest.

Is there?
@mlwelles mlwelles mentioned this issue Feb 9, 2017
Merged
@jpsim jpsim added the enhancement Ideas for improvements of existing features and rules. label Feb 10, 2017
@marcelofabri
Copy link
Collaborator

Implemented in #1299 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpsim @mlwelles @marcelofabri