Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not produce 404.xhtml in epub and htmlhelp #230

Closed
methane opened this issue May 7, 2024 · 1 comment · Fixed by #231
Closed

Do not produce 404.xhtml in epub and htmlhelp #230

methane opened this issue May 7, 2024 · 1 comment · Fixed by #231
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@methane
Copy link
Contributor

methane commented May 7, 2024

Python uses this extension but I don't want include it in ePub build.
Would you check if app.builder.embedded before generating 404 page?
@methane methane mentioned this issue May 7, 2024
Merged
@humitos
Copy link
Member

humitos commented May 7, 2024

Hi. Yeah, that makes sense. I think this page should only be generated if the builder is HTML (that means, no PDF nor ePUB or similars). Do you like to open a PR for this? 🙏🏼

@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels May 7, 2024
@methane methane mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not create 404 page for embedded (e.g. ePub)
2 participants
@methane @humitos