Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Image): match new alignment selectors #992

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Oct 11, 2024

🎫 Fix RM-11105, RM-11116

🧰 Changes

  • update our image alignment rulesets to match the new MDX selectors

🧬 QA & Testing

Checkout the style/image/match-new-alignment-selectors branch, run start, and open up this example in the playground. Try switching the <Image[align]> prop from "left" to "center" to "right". If it’s reflected correctly in the right-side render, this worked! 🎉

@rafegoldberg rafegoldberg added bug Something isn't working styles Changes related to visual styling labels Oct 11, 2024
Copy link
Collaborator

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

@rafegoldberg rafegoldberg merged commit 73bca2b into next Oct 11, 2024
13 checks passed
@rafegoldberg rafegoldberg deleted the style/image/match-new-alignment-selectors branch October 11, 2024 17:02
rafegoldberg pushed a commit that referenced this pull request Oct 14, 2024
## Version 7.6.7

### ✨ New & Improved

* **Image:** match new alignment selectors ([#992](#992)) ([73bca2b](73bca2b))

### 🛠 Fixes & Updates

* better tag handling ([#991](#991)) ([e6aa82d](e6aa82d))
* respect the top-level `copyButtons` option ([#990](#990)) ([1242413](1242413)), closes [#964](#964) [/github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts#L28](https://github.com/readmeio//github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts/issues/L28) [/github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts#L28](https://github.com/readmeio//github.com/readmeio/markdown/blob/96f9644f04e6d8e3ffff6f9c014432f901c0b804/lib/compile.ts/issues/L28) [/github.com/readmeio/markdown/blob/b9502adb306f099cd91e005df17c0be252019814/options.js#L1-L22](https://github.com/readmeio//github.com/readmeio/markdown/blob/b9502adb306f099cd91e005df17c0be252019814/options.js/issues/L1-L22)

### 📘 Tests & Docs

* readme updates ([#993](#993)) ([3a4e30d](3a4e30d))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor Author

This PR was released!

🚀 Changes included in v7.6.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released styles Changes related to visual styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants