Regression in react-native-config iOS scriptPhases script path resolution in react-native 0.75-rc / cli v14 alpha11

[mikehardy]

Old Version

0.74.2

New Version

0.75.0-rc.2

Description

The CLI is documented to resolve the react-native-config.js configuration iOS scriptPhases path of a module as a module-relative directory, but is currently resolving it as project-relative instead of module-relative

Steps to reproduce

Install react-native 0.75.0-rc.2
Install @react-native-firebase/app
yarn pod-install (or cd ios && pod install)

You will see an error

Affected Platforms

Build - MacOS

Output of npx react-native info

info Fetching system and libraries information...
System:
  OS: macOS 14.5
  CPU: (8) arm64 Apple M2
  Memory: 56.75 MB / 16.00 GB
  Shell:
    version: 3.2.57
    path: /bin/bash
Binaries:
  Node:
    version: 18.20.3
    path: ~/.nvm/versions/node/v18.20.3/bin/node
  Yarn:
    version: 3.6.4
    path: ~/.nvm/versions/node/v18.20.3/bin/yarn
  npm:
    version: 10.8.1
    path: ~/.nvm/versions/node/v18.20.3/bin/npm
  Watchman:
    version: 2024.06.24.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/mike/.asdf/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK:
    API Levels:
      - "28"
      - "30"
      - "33"
      - "34"
    Build Tools:
      - 28.0.3
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 33.0.0
      - 33.0.1
      - 33.0.2
      - 34.0.0
    System Images:
      - android-23 | ARM 64 v8a
      - android-24 | Google Play Intel x86 Atom
      - android-30 | Google APIs ARM 64 v8a
      - android-30 | Google Play ARM 64 v8a
      - android-33 | ARM 64 v8a
      - android-33 | Google APIs ATD ARM 64 v8a
      - android-34 | Google APIs ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
      - android-VanillaIceCream | Google APIs ARM 64 v8a
      - android-VanillaIceCream | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.15989.150.2411.11948838
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/javac
  Ruby:
    version: 3.3.3
    path: /Users/mike/.asdf/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.0.0-rc-fb9a90fa48-20240614
    wanted: 19.0.0-rc-fb9a90fa48-20240614
  react-native:
    installed: 0.75.0-rc.2
    wanted: 0.75.0-rc.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

Adding a custom script phase for Pod RNFBApp: [RNFB] Core Configuration

[!] Invalid `Podfile` file: No such file or directory @ rb_sysopen - /Users/mike/work/invertase/rnfbdemo/rnfbdemo/ios/ios_config.sh.

 #  from /Users/mike/work/invertase/rnfbdemo/rnfbdemo/ios/Podfile:18
 #  -------------------------------------------
 #  target 'rnfbdemo' do
 >    config = use_native_modules!
 #    use_frameworks! :linkage => :static
 #  -------------------------------------------

Reproducer

https://github.com/mikehardy/rnfbdemo/blob/rn75/make-demo.sh

Screenshots and Videos

Note that the reproducer currently works because I have patched via patch-package our script paths to probe this error
If you remove the patches it fails

I have attempted to document this as well as possible, and with some help might be able to make a PR, in the CLI repository but since it's a regression that causes a build error for us in react-native 0.75 (and maybe affects others?) I wanted to log it here

react-native-community/cli#2439

[mikehardy]

Logged this before seeing #341 😆 - closing this one.