Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Uncontrolled Components #37

Merged
merged 7 commits into from
Feb 28, 2019
Merged

Translate Uncontrolled Components #37

merged 7 commits into from
Feb 28, 2019

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Feb 9, 2019

Перевод взят из Crowdin без изменений — https://crowdin.com/translate/react/2090/en-ru

@lex111 lex111 added work in progress Author opened the pull-request but it's still being worked on from-crowdin This translation came from Crowdin labels Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
Closed
88 tasks
@lex111 lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 10, 2019
@lex111
Copy link
Member Author

lex111 commented Feb 10, 2019

@gaearon посмотри, пожалуйста.

gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо поработать над понятностью. Мне кажется, смысл ускользает.

content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
@another-guy another-guy self-assigned this Feb 14, 2019
another-guy
another-guy requested changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 извини, только сейчас смог внимательно прочитать перевод.

content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
content/docs/uncontrolled-components.md Outdated Show resolved Hide resolved
@another-guy another-guy removed their assignment Feb 15, 2019
@another-guy @lex111
Apply suggestions from code review by @another-guy
33936d5 
Co-Authored-By: lex111 <lex61rus@gmail.com>
@Heegiiny Heegiiny mentioned this pull request Feb 21, 2019
Merged
@another-guy another-guy self-assigned this Feb 22, 2019
@thechch
Copy link
Contributor

thechch commented Feb 23, 2019

Я использовал "управляемые"/"неуправляемые" компоненты, в этом переводе "контролируемые"/"неконтролируемые". Необходимо придти к какому то единому варианту перевода.

@another-guy
Copy link
Collaborator

@thechch в нашем словаре вот так указано:

(un)controlled component -- (не)контролируемый компонент

@thechch
Copy link
Contributor

thechch commented Feb 24, 2019

@another-guy понял + принял

@another-guy another-guy removed their assignment Feb 28, 2019
@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed under discussion labels Feb 28, 2019
another-guy
another-guy approved these changes Feb 28, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 спасибо за работу и за терпение! 💯

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ru-reactjs ready!

Built with commit a89d748

https://deploy-preview-37--ru-reactjs.netlify.com

@another-guy
Copy link
Collaborator

another-guy commented Feb 28, 2019 •
edited
Loading

А ещё подумал, а почему и правда контролируемые, а не управляемые? По-моему последний попроще и "по-русски" звучит, что думаешь? cc @another-guy

@lex111
По-идее, да. "управляемые" это русское слово, а "контролируемые" -- заимствованное. Но у нас в словаре уже есть правило. Поэтому я завёл бы issue на вычитку после того, как общий перевод будет готов. Лучше быть консистетными сейчас.

@lex111
Copy link
Member Author

lex111 commented Feb 28, 2019 •
edited
Loading

Поэтому я завёл бы issue на вычитку после того, как общий перевод будет готов. Лучше быть консистетными сейчас

👍 (создал ишью #202 )

@lex111 lex111 merged commit 89b870f into master Feb 28, 2019
@lex111 lex111 deleted the uncontrolled-components branch February 28, 2019 03:46
@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ru-reactjs ready!

Built with commit 16ee9ea

https://deploy-preview-37--ru-reactjs.netlify.com

@lex111 lex111 mentioned this pull request Feb 28, 2019
Closed
@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ru-reactjs ready!

Built with commit 541b699

https://deploy-preview-37--ru-reactjs.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thechch thechch thechch left review comments

@gaearon gaearon gaearon requested changes

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
from-crowdin This translation came from Crowdin needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lex111 @thechch @another-guy @gaearon