Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method `lookup' for Webpacker::Manifest:Class #776

Closed
3 tasks
beaver1992 opened this issue Aug 31, 2017 · 4 comments
Closed
3 tasks

undefined method `lookup' for Webpacker::Manifest:Class #776

beaver1992 opened this issue Aug 31, 2017 · 4 comments

Comments

@beaver1992
Copy link

Help us help you! Please choose one:

  • My app crashes with react-rails, so I've included the stack trace and the exact steps which make it crash.
  • My app doesn't crash, but I'm getting unexpected behavior. So, I've described the unexpected behavior and suggested a new behavior.
  • [+] I'm trying to use react-rails with another library, but I'm having trouble. I've described my JavaScript management setup (eg, Sprockets, Webpack...), how I'm trying to use this other library, and why it's not working.
  • I have another issue to discuss.

After upgrading to Webpacker 3.0 get this error:
'undefined method `lookup' for Webpacker::Manifest:Class'

use with react-rails. Before update everything was good.

@rmosolgo
Copy link
Member

Sounds like this library needs some work to support webpacker 3.0 :S

@BookOfGreg
Copy link
Member

BookOfGreg commented Aug 31, 2017

Not sure what changed, Webpacker::Manifest.lookup is still there @ https://github.com/rails/webpacker/blob/v3.0.0/lib/webpacker/manifest.rb#L25

Edit: It's not a class method anymore, I'm currently researching how to get the current instance of manifest and will PR it in.

@beaver1992
Copy link
Author

beaver1992 commented Aug 31, 2017

Webpacker updated the manifest lookup API
rails/webpacker#726

@BookOfGreg
Copy link
Member

BookOfGreg commented Aug 31, 2017

Found it: Yep they made it a singleton.
I'll PR something in to be compatible with their PR
rails/webpacker#636

rails/webpacker@c895cb6#diff-ccbc9196f591353b07190e7063ca0881R24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants