Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does react_ujs > 2.7.1 depend on react_ujs@2.7.1? #1346

Open
ajesler-hatch opened this issue Oct 9, 2024 · 0 comments
Open

Why does react_ujs > 2.7.1 depend on react_ujs@2.7.1? #1346

ajesler-hatch opened this issue Oct 9, 2024 · 0 comments
Assignees

Comments

@ajesler-hatch
Copy link

ajesler-hatch commented Oct 9, 2024

Help us help you! Have you looked for similar issues? Do you have reproduction steps? Contributing Guide

Steps to reproduce

yarn upgrade react_ujs when I'm on react_ujs@2.7.1 and have react-rails@3.2.1 installed, and don't have any version constraints in my package.json.

Expected behavior

The installed version of react_ujs is updated, to 3.2.1 at the time of writing.

Actual behavior

react_ujs@3.2.1 is installed, but react_ujs@2.7.1 isn't removed from the yarn.lock file.

System configuration

  • Shakapacker or Sprockets version: I'm using vite@5.4.6, via this method
  • React-Rails version: 3.2.1
  • Rect_UJS version: 2.7.1
  • Rails version: 7.0
  • Ruby version: 3.3.5

react_ujs@3.0.0 and above has a dependency on react_ujs@2.7.1 specified in the package.json. This was introduced in a4bd5b3#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Is this expected behaviour that I'm not understanding?

$ yarn why react_ujs

yarn why v1.22.19
[1/4] 🤔  Why do we have the module "react_ujs"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "react_ujs@3.2.1"
info Has been hoisted to "react_ujs"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "276KB"
info Disk size with unique dependencies: "6.63MB"
info Disk size with transitive dependencies: "60.01MB"
info Number of shared dependencies: 65
=> Found "react_ujs#react_ujs@2.7.1"
info This module exists because "react_ujs" depends on it.
info Disk size without dependencies: "144KB"
info Disk size with unique dependencies: "144KB"
info Disk size with transitive dependencies: "144KB"
info Number of shared dependencies: 0
✨  Done in 0.31s.
@Judahmeek Judahmeek self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants