fix(Schedulers): Throwing a falsy error in a scheduled function no longer results in strange error objects. #6594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
commented
Sep 14, 2021
| @@ -63,7 +63,7 @@ describe('Scheduler.queue', () => { | |||
| const actions: Subscription[] = []; | |||
| let action2Exec = false; | |||
| let action3Exec = false; | |||
| let errorValue = undefined; | |||
| let errorValue: any = undefined; | |||
benlesh
commented
Sep 14, 2021
| expect(err.errors).to.deep.equal([err1, err2]); | ||
| expect(err.name).to.equal('UnsubscriptionError'); | ||
| expect(err.stack).to.be.a('string'); | ||
| if (err instanceof UnsubscriptionError) { |
benlesh
commented
Sep 14, 2021
| // HACK: Since code elsewhere is relying on the "truthiness" of the | ||
| // return here, we can't have it return "" or 0 or false. | ||
| // TODO: Clean this up when we refactor schedulers mid-version-8 or so. | ||
| errorValue = e ? e : new Error('Falsy action error'); |
There was a problem hiding this comment.
To fix CI ts@latest and correct a weird bit of code that TS 4.4 helped catch.
kwonoj
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because TS 4.4 now infers
unknownforcatchblocks, we had to make some adjustments.This also helped us catch a type problem where we were maybe creating
new Error(false)ornew Error(''), etc, in some cases.