fix(bindCallback): create subject within factory #6369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes
bindCallback
andbindNodeCallback
. In v6 the internal subject was created in the factory that returns the bound observable:rxjs/src/internal/observable/bindCallback.ts
Lines 196 to 198 in 881cacd
However, in v7, the subject creation was inadvertently moved outside of the factory:
rxjs/src/internal/observable/bindCallbackInternals.ts
Lines 38 to 42 in f9d29f7
With it outside of the factory, calls subsequent to the first were ineffectual: the arguments passed were ignored and the previous result was returned.
This PR add some failing tests and moves the subject creation back into the factory.
Related issue (if exists): Nope