Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% chance of runtime error if config.useDeprecatedSyncErrorHandling is enabled #6271

Closed
benlesh opened this issue Apr 27, 2021 · 1 comment · Fixed by #6272
Closed

100% chance of runtime error if config.useDeprecatedSyncErrorHandling is enabled #6271

benlesh opened this issue Apr 27, 2021 · 1 comment · Fixed by #6272
Assignees
@benlesh

Comments

@benlesh
Copy link
Member

benlesh commented Apr 27, 2021

Look at this dumbness:

rxjs/src/internal/Observable.ts

Line 278 in 7be67fa

dest._syncErrorHack_isSubscribing = false;

I'm not sure how I wrote that and thought "okay, this is perfect", but clearly, we are missing a test or something. haha.

Fortunately, 99.9999% of people aren't using this mode. BECAUSE IT'S BAD.
@benlesh benlesh self-assigned this Apr 27, 2021
@benlesh
Copy link
Member Author

benlesh commented Apr 27, 2021

cc @leggechr

benlesh added a commit to benlesh/rxjs that referenced this issue Apr 27, 2021
@benlesh
fix: resolve run-time errors when using deprecated sync error handling
36f90b4 
Fixes a should-be-obvious issue where we were making sure `dest` was `undefined`, then trying to set a property on it.

fixes ReactiveX#6271
@benlesh benlesh mentioned this issue Apr 27, 2021
Merged
benlesh added a commit that referenced this issue Apr 27, 2021
@benlesh
fix: resolve run-time errors when using deprecated sync error handling (
35daaf7 
#6272)

Fixes a should-be-obvious issue where we were making sure `dest` was `undefined`, then trying to set a property on it.

fixes #6271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlesh benlesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resolve run-time errors when using deprecated sync error handling benlesh/rxjs
1 participant
@benlesh