chore: Add typesVersions to package.json #6229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix issues with VS Code auto-import, as described here in this issue: https://github.com/microsoft/TypeScript/issues/43034\#issuecomment-820621280 Related ReactiveX#6067
cartant
reviewed
Apr 17, 2021
| @@ -6,6 +6,9 @@ | |||
| "module": "./dist/esm5/index.js", | |||
| "es2015": "./dist/esm/index.js", | |||
| "types": "./dist/types/index.d.ts", | |||
| "typesVersions": { | |||
| ">=4.0": { "*": [ "dist/types/*" ] } | |||
There was a problem hiding this comment.
question: Could we use this to express that the minimum supported version is 4.2? I mean, we're not going to support anything older than that.
cartant
approved these changes
Apr 17, 2021
|
Shit. I wanted to get this into the RC :\ |
benlesh
added a commit
to benlesh/rxjs
that referenced
this pull request
Apr 20, 2021
This reverts commit 659a623.
benlesh
added a commit
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix issues with VS Code auto-import, as described here in this issue: https://github.com/microsoft/TypeScript/issues/43034\#issuecomment-820621280
Related #6067