fix(Symbol.observable): properly defined as a unique symbol.
#5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
approved these changes
Nov 2, 2020
|
Added breaking change note to show in up in the CHANGELOG. |
kwonoj
added a commit
that referenced
this pull request
Apr 12, 2021
kwonoj
added a commit
that referenced
this pull request
Apr 15, 2021
benlesh
pushed a commit
that referenced
this pull request
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5861
Resolves #4415
This is also related to issues here: benlesh/symbol-observable#41
I don't think we can publish this in 6.x, as it will break people using older versions of
@types/node, however, we do need to set an upper bounds for@types/nodeand version 6.x.