Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout crates & retain timeoutError object eagerly #5491

Closed
kwonoj opened this issue Jun 15, 2020 · 0 comments · Fixed by #5497
Closed

timeout crates & retain timeoutError object eagerly #5491

kwonoj opened this issue Jun 15, 2020 · 0 comments · Fixed by #5497
Assignees
Labels
bug Confirmed bug

Comments

@kwonoj
Copy link
Member

kwonoj commented Jun 15, 2020

Bug Report

Current Behavior
A clear and concise description of the behavior.

Reproduction

rx.interval(10).pipe(
  take(3),
  filter(() => false),
  timeout(1000)
).subscribe((x) => { console.log(x) }, null, () => { console.log('complete') });

Expected behavior
above code snippet never timeouts, but inspecting heap will reveal retainer to timeoutError object:
image

Environment

  • Runtime: [e.g. Node v${x}, Chrome v${x}]
  • RxJS version:
  • (If bug is related) Loader, build configuration: [e.g webpack, angular-cli version, config]

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Discussed with @benlesh and we would like to treat this as bug, avoid creating error object unless actual timeout occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant