We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current Behavior A clear and concise description of the behavior.
Reproduction
rx.interval(10).pipe( take(3), filter(() => false), timeout(1000) ).subscribe((x) => { console.log(x) }, null, () => { console.log('complete') });
Expected behavior above code snippet never timeouts, but inspecting heap will reveal retainer to timeoutError object:
timeoutError
Environment
Possible Solution
Additional context/Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.
Discussed with @benlesh and we would like to treat this as bug, avoid creating error object unless actual timeout occurs.
The text was updated successfully, but these errors were encountered:
fix(timeout): defer error creation until timeout occurs
543645a
- closes #5491
fix(timeout): defer error creation until timeout occurs (#5497)
3be9840
fix(timeout): defer error creation until timeout occurs (ReactiveX#5497)
dca4773
- closes ReactiveX#5491
kwonoj
Successfully merging a pull request may close this issue.
Bug Report
Current Behavior
A clear and concise description of the behavior.
Reproduction
(you can use https://stackblitz.com/ to create one to attach here)
Expected behavior
above code snippet never timeouts, but inspecting heap will reveal retainer to
timeoutError
object:Environment
Possible Solution
Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.
Discussed with @benlesh and we would like to treat this as bug, avoid creating error object unless actual timeout occurs.
The text was updated successfully, but these errors were encountered: