Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(concatWith): adds concatWith #4988

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Aug 28, 2019

concat operator, not static function, is still deprecated, but in favor of concatWith.

NOTE: First real usage of TestScheduler run mode in library. Enabled me to format the document with Prettier :)

@benlesh benlesh force-pushed the concatWith branch 2 times, most recently from 4637407 to 44009e3 Compare August 28, 2019 04:20
@benlesh benlesh marked this pull request as ready for review August 28, 2019 04:20
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

`concat` operator, not static function, is now deprecated, but in favor of `concatWith`.

NOTE: First real usage of `TestScheduler` run mode in library. Enabled me to format the document with Prettier :)
@benlesh benlesh merged commit dc89736 into ReactiveX:master Oct 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants