Reduce scheduler footprint for default usage of shareReplay, timeInterval, and timestamp #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
changed the title
cartant
approved these changes
Sep 3, 2019
| @@ -1,5 +1,4 @@ | |||
| import { async } from '../scheduler/async'; | |||
| import { OperatorFunction, SchedulerLike, Timestamp as TimestampInterface } from '../types'; | |||
| import { OperatorFunction, Timestamp as TimestampInterface, TimestampProvider, Timestamp } from '../types'; | |||
There was a problem hiding this comment.
Timestamp as TimestampInterface does not appear to be used.
| return (this.scheduler || queue).now(); | ||
| private _getNow(): number { | ||
| const { timestampProvider: scheduler } = this; | ||
| return scheduler ? scheduler.now() : Date.now(); |
There was a problem hiding this comment.
Is there anything to be gained by keeping the scheduler terminology in here? I mean, it could be a scheduler, but it's entirely possible it could be something else. Why not just use timestampProvider as the name for the local const?
The aim here is to simplify `ReplaySubject` by removing a unnecessary feature that pulled in a lot of scheduler code via `QueueScheduler` and `ObserveOnSubscriber`, which in turn pulled in `AsyncScheduler`, and a lot of other related code. Instead, we're going to pull in a new, smaller `TimestampProvider` type, that simply has the necessary `now` method on it, meaning that `Date` or `performance` could be used as arguments to the `ReplaySubject` constructor. BREAKING CHANGE: `ReplaySubject` no longer schedules emissions when a scheduler is provided. If you need that behavior, please compose in `observeOn` using `pipe`, for example: `new ReplaySubject(2, 3000).pipe(observeOn(asap))`
Refactors timestamp to accept a `TimestampProvider`, which is any object with a `now` method that returns a number. This means pulling in less code for the use of the `timestamp` operator. Also removes unecessary internal class `Timestamp` which could have just been an interface that we already had.
benlesh
force-pushed
the
replaysubject-remove-observeon
branch
from
f5c083f to
3c3d807
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
ReplaySubject,timeInterval, andtimestampto remove reliance on Schedulers that were not necessary. This should help drastically reduce the amount of code pulled in for defaultshareReplayusage ortimestampusage.See commit messages for more details.
NOTE: Breaking change in that
ReplaySubjectwill no longer have inherentobserveOnbehavior if provided a scheduler.