fix(types): add Boolean signature to filter #4961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4959
Description:
This PR adds another signature overload to
filter
to matchBoolean
predicates. This solves the problem identified in #4959 and is sufficiently specific that I cannot foresee it effecting further problems.I've added a conventional test and a dtslint test.
Other operators that have a similar issue are:
find
,first
,last
andtakeWhile
. If this fix is approved, I'll have a look at what can be done for those (first
andlast
are a little more complicated, as they support a default value).@benlesh @rkirov
Related issue (if exists): #4959