-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fetch): Making fetch happen #4702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `fromFetch` implementation that uses native `fetch` - Adds tests and basic documentation - DOES NOT polyfill fetch
benlesh
force-pushed
the
make-fetch-happen
branch
from
April 10, 2019 16:02
119b3bc
to
de08586
Compare
Pull Request Test Coverage Report for Build 8363
💛 - Coveralls |
From Core Team Meeting
👍 |
🎉 I think this will close #4534 |
cartant
reviewed
Apr 13, 2019
cartant
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BioPhoton
pushed a commit
to BioPhoton/rxjs
that referenced
this pull request
May 15, 2019
* feat(fetch): Making fetch happen - Adds `fromFetch` implementation that uses native `fetch` - Adds tests and basic documentation - DOES NOT polyfill fetch * fixup! feat(fetch): Making fetch happen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromFetch
implementation that uses nativefetch
Overview
I think, long term, we should deprecate the
ajax
methods and try to move people towards fetch now that bothfetch
andAbortController
are universally implemented (everywhere but IE) and polyfills are available.Maintaining our own ajax implementation is challenging, and this is lot more lightweight and full featured.