Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationKind not exported #4513

Closed
cartant opened this issue Jan 30, 2019 · 0 comments
Closed

NotificationKind not exported #4513

cartant opened this issue Jan 30, 2019 · 0 comments
Labels
AGENDA ITEM Flagged for discussion at core team meetings bug Confirmed bug

Comments

@cartant
Copy link
Collaborator

cartant commented Jan 30, 2019

Bug Report

Current Behavior

6.4.0 introduced a const enum: NotificationKind. However, that enum is not exported:

/* Notification */
export { Notification } from './internal/Notification';

That means that it's not possible to create a Notification instance (without resorting to an as any assertion).

This was a breaking change for me, as the tests for rxjs-spy need to be able to create Notification instances. (It's also a breaking change because current calls to the constructor - like new Notification("N", "alice") - are now invalid.)

cartant added a commit to cartant/rxjs that referenced this issue Jan 30, 2019
@benlesh benlesh added bug Confirmed bug AGENDA ITEM Flagged for discussion at core team meetings labels Jan 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AGENDA ITEM Flagged for discussion at core team meetings bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants