perf(internal): use strict equality for isObject() #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `isObject(x)` use triple equal instead of double equal comparison with `null`, since `undefined` will be ruled out via the `typeof`, and therefore it's sufficient to just check for `null` initially.
Pull Request Test Coverage Report for Build 7945
💛 - Coveralls |
cartant
approved these changes
Jan 24, 2019
benlesh
approved these changes
Jan 24, 2019
|
Thank you @bmeurer! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
isObject(x)use triple equal instead of double equal comparisonwith
null, sinceundefinedwill be ruled out via thetypeof, andtherefore it's sufficient to just check for
nullinitially.