fix(typescript): Update typings for race to support proper return types #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
reviewed
Jan 11, 2019
src/internal/observable/race.ts
Outdated
| export function race<A, B, C, D>(a: Observable<A>, b: Observable<B>, c: Observable<C>, d: Observable<D>): Observable<A> | Observable<B> | Observable<C> | Observable<D>; | ||
| export function race<A, B, C, D, E>(a: Observable<A>, b: Observable<B>, c: Observable<C>, d: Observable<D>, e: Observable<E>): Observable<A> | Observable<B> | Observable<C> | Observable<D> | Observable<E>; | ||
| // tslint:enable:max-line-length | ||
|
|
||
| export function race<T>(observables: Array<Observable<T>>): Observable<T>; | ||
| export function race<T>(observables: Array<Observable<any>>): Observable<T>; | ||
| export function race<T>(...observables: Array<Observable<T> | Array<Observable<T>>>): Observable<T>; |
There was a problem hiding this comment.
I don't understand why
export function race<T>(...observables: Array<Observable<T> | Array<Observable<T>>>): Observable<T>;
needs to be an overload signature. I can see why it is the implementation signature, but why it needs to be an overload baffles me. Don't the others handle the scenarios that are bundled into this signature?
Do we really need to keep this already-existing signature? Can it be removed?
LGTM, otherwise.
Pull Request Test Coverage Report for Build 7888
💛 - Coveralls |
kwonoj
approved these changes
Jan 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types returned by race were incorrect. This ought to resolve that.