Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundle): don't export operators twice #4310

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Oct 31, 2018

@coveralls
Copy link

coveralls commented Oct 31, 2018

Pull Request Test Coverage Report for Build 7553

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.967%

Files with Coverage Reduction New Missed Lines %
src/internal/observable/fromPromise.ts 1 87.5%
src/internal/observable/fromIterable.ts 2 95.24%
src/internal/observable/fromObservable.ts 2 83.33%
Totals Coverage Status
Change from base Build 7551: 0.2%
Covered Lines: 5786
Relevant Lines: 5967

💛 - Coveralls

src/internal/umd.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit 2399f6e into ReactiveX:master Nov 28, 2018
@benlesh
Copy link
Member

benlesh commented Nov 28, 2018

Thanks, @alan-agius4

@alan-agius4 alan-agius4 deleted the fix_double_operators branch November 28, 2018 19:47
@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants