-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delayWhen doesn't emit when the duration selector is empty() #3663
Comments
does work as intended, so this seems to be an issue with the synchronicity. |
…hronously This fixes an issue where delayWhen would not re-emit a source emission if the duration selector completed synchronously. ReactiveX#3663
Looking at the existing implementation of |
Yeah, I thought about this when first looking at it as well and then just forgot about it. I think my first PR attempt is no good. We'll need a better solution. |
OK, |
…hronously This fixes an issue where delayWhen would not re-emit a source emission if the duration selector completed synchronously. fixes ReactiveX#3663
…hronously This fixes an issue where delayWhen would not re-emit a source emission if the duration selector completed synchronously. fixes ReactiveX#3663
The OP here isn't valid. |
@benlesh Sorry, I messed up my OP when editing it. It's missing the delayWhen. The correct example was
|
…hronously This fixes an issue where delayWhen would not re-emit a source emission if the duration selector completed synchronously. fixes ReactiveX#3663
…hronously (#3664) * fix(delayWhen): Emit source value if duration selector completes synchronously This fixes an issue where delayWhen would not re-emit a source emission if the duration selector completed synchronously. fixes #3663 * docs(delayWhen): Deprecate completion of notifier triggering source emission This deprecates the behavior that the completion of the notifier observable will cause the source emission to be emitted on the output observable.
RxJS version: 6.1.0
Code to reproduce:
Expected behavior:
This should log
42
immediately, asempty
completes immediately which according to the docs should suffice even if the duration selector doesn't emit:Actual behavior:
The observable completes without emission.
The text was updated successfully, but these errors were encountered: