Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Change MS MicrosoftDependencyResolver to require IKeyedServiceProvider in ctor #1116

Closed
dpvreony opened this issue Mar 1, 2024 · 2 comments
Labels

Comments

@dpvreony
Copy link
Member

dpvreony commented Mar 1, 2024

Please note although we can't commit to any timeline, priority will be given to those who are Contributors to the project.

If this is a question please ask on StackOverflow.

Is your feature request related to a problem? Please describe.
With #1075 to avoid a breaking change that would effectively drop NET6 early and cause a headache it was suggested to revisit how IKeyedServiceProvider logic works in the DI wrapper.

With #1075 it carries out an interface type check to see if it's using IKeyedServiceProvider.

Describe the solution you'd like
This can be simplified by changing the constructor to require IKeyedServiceProvider instead of IServiceProvider. The default implementation of ServiceProvider uses IKeyedServiceProvider as of net 8.
Then we can remove the if checks and the older contract internal class that's in there for net6.

Describe alternatives you've considered
Leave as is

Describe suggestions on how to achieve the feature

Additional context

@dpvreony
Copy link
Member Author

dpvreony commented May 9, 2024

technically we've already broken net6 package support as the framework is using v8 of packages

@dpvreony dpvreony closed this as completed May 9, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant