Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the DI Microsoft to use KeyedServiceProvider insted of ContractDictionary #1074

Closed
OleksandrTsvirkun opened this issue Feb 16, 2024 · 1 comment
Labels

Comments

@OleksandrTsvirkun
Copy link
Contributor

Microsoft.Extensions.DependencyInjection 8.0 provides an implementation for keyed service type registrations.
Now Splat.Microsoft.Extensions.DependencyInjection provides own ContractDictionary for service registrations with contract.
It leads to issues when Splat's IDependencyResolver and Microsoft's IServiceProvider provide two different instances for singleton object.
I want to be sure both of provide the same instance for singleton object.

As far as Microsoft.Extensions.DependencyInjection provides the similat interface for registering keyed (contracted) service I suggest just update the implementation of Splat.Microsoft.Extensions.DependencyInjection adapter.

I've already done it and my changes successfully passed all tests.

Copy link

github-actions bot commented Jun 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant