Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GroupOnObservable fires OnComplete if the Source does #937

Closed
dwcullop opened this issue Sep 4, 2024 · 2 comments
Closed

[Bug]: GroupOnObservable fires OnComplete if the Source does #937

dwcullop opened this issue Sep 4, 2024 · 2 comments
Labels

Comments

@dwcullop
Copy link
Member

dwcullop commented Sep 4, 2024

Describe the bug 🐞

The GroupOnObservable fires OnComplete as soon as the source fires it, which will prematurely close the stream (sometimes before any groups can actually be made).

Step to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Reproduction repository

https://github.com/reactivemarbles/DynamicData/

Expected behavior

It shouldn't fire OnComplete until the source fires OnComplete and ALL Grouping Observables have fired their OnComplete because grouping changes could come in at any time before then.

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

DynamicData Version

9.0.4

Additional information ℹ️

No response

@dwcullop
Copy link
Member Author

dwcullop commented Sep 6, 2024

Fixed via #938

@dwcullop dwcullop closed this as completed Sep 6, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant