-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do I configure tests to run in babel stage=0 #165
Comments
@yakirn fwiw,there is a related issue targeting the update from babel 5 to 6 in the repository that features the template used in this generator. not sure if they are related, but it might be interesting either way react-webpack-generators/react-webpack-template/issues/11. |
Hi @yakirn, currently we are still using babel 5, so there may be some stuff that is currently not working. |
@weblogixx @sthzg Thank you for your answers. |
yes, it should work when you disable the isparta-loading and update to babel 6. I have all parts ready but unfortunately still have to wait for isparta-loader to be updated. If this is not happening in the nearer future, I will have to disable it (or fork the project, the change that needs to be done is just updating the package.json). |
@yakirn: The generator was just updated to use babel 6. It should work with the new version without problems. Note: Only newly created projects (after updating the generator) will be build with babel 6. |
Ok, I managed to run the tests after I disabled isparta.
this time I didn't change anything. it's the pure generator's code. npm start works. |
@yakin: |
Think that should be done with the update. Closing this. If there are any other errors, feel free to open a new ticket. |
I've modified cfg/dev.js to support stage 0 features of babel:
then I added a stage 0 feature such as class properties to src/components.Main.js
https://github.com/jeffmo/es-class-static-properties-and-fields
hit npm start, and everything works fine.
I've noticed cfg/test.js has two babel loaders (the second is for test coverage?)
I tried to add stage=0 for the first one and for both as a query string, using the two options that are suggested here (query string and query property):
https://github.com/babel/babel-loader/tree/v5.3.2#options
either way, running
npm test
fails with syntax error where the stage 0 code is.any idea how to solve this?
Thanks!
The text was updated successfully, but these errors were encountered: