Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support json file type #718

Merged
merged 1 commit into from
May 17, 2024
Merged

feat: support json file type #718

merged 1 commit into from
May 17, 2024

Conversation

roryabraham
Copy link
Contributor

This is a simple PR to add JSON as a file type.

@roryabraham roryabraham mentioned this pull request May 6, 2024
Closed
50 tasks
vonovak
vonovak approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a goal of this package to provide a "database" of different mimes / utis / extensions.
But json seems fairly common so why not add it 👍.

I'll release this in a few days when I get back from vacation.

Thank you! 🙂

@vonovak vonovak merged commit 9118ca0 into react-native-documents:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonovak vonovak vonovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roryabraham @vonovak