Upcoming v0.65.1 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.65 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.65.0 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

List of PRs & cherry picks requested

• facebook/react-native@d75683a
• facebook/react-native@06e31c7
• facebook/react-native@d272880
• facebook/react-native@842bcb9

Local commits to backport to main

• facebook/react-native@cae0637
• facebook/react-native@f6accd2 (need to check if this is actually needed in main)
• facebook/react-native@5aae7fc
• facebook/react-native@5f7deb5 (not necessarily to back port but we need to talk about this need for future releases)
• facebook/react-native@98e1734 (not necessarily to back port, since we had to revert, but we need to talk about this need for future releases)

[Theofilos-Chamalis]

First of all thank you very much for the release of v0.65! I 've tested it on an existing app and with Hermes enabled it feels even snappier on Android :)

What I'd like to request for v0.65.1 if possible is a bugfix that was mentioned on the v0.65 discussion about the taps on views outside parent bounds that are not working on Android. The PR link (if I am correct) is the following: facebook/react-native@e35a963 and hopefully we could see this in the next release!

Cheers and thanks again for your work!

[elicwhite]

First of all thank you very much for the release of v0.65! I 've tested it on an existing app and with Hermes enabled it feels even snappier on Android :)

What I'd like to request for v0.65.1 if possible is a bugfix that was mentioned on the v0.65 discussion about the taps on views outside parent bounds that are not working on Android. The PR link (if I am correct) is the following: facebook/react-native@e35a963 and hopefully we could see this in the next release!

Cheers and thanks again for your work!

That change is pretty major, and while it makes sense that people want it in a release, it might make sense to bake it longer at Facebook in case it needs to be reverted or tweaked to be stable at scale in the Facebook app.

[truongngodang]

I got a issue when start app build release on ios rn 0.65 'RCTFatalException: Could not get BatchedBridge, make sure your bundle is packaged correctly', reason: 'Could not get BatchedBridge, make sure your bundle is packaged correctly'

[mrousavy]

@truongngodang does that happen in the bare React Native template or in your own app? If it's happening in your own app, please check if it's also happening in the template. If not, you might have missed something while upgrading.

[Bardiamist]

I noticed that react-test-renderer still 17.0.1 in RN 0.65.0. But react is up to 17.0.2. Should I use 17.0.1 or 17.0.2? Maybe need to cherry pick facebook/react-native@d272880

[kelset]

@Bardiamist good catch, I'll add it to the list

[taylorkline]

facebook/react-native@842bcb9 should fix a regression on Android where suddenly some components are transparent. Would be nice to have cherry-picked if it applies cleanly.

[vskavgaci]

log keypress events from numeric keys on android fix facebook/react-native@bd52916

[kelset]

@vskavgaci I don't know where you've found that commit but is not in the repo:

So it can't be cherry picked

[matt-oakes]

@kelset It looks to be from this unmerged PR. So yes, it can't be cherry picked until it's merged in

[kelset]

gotcha, thanks @matt-oakes 👍

[Bardiamist]

facebook/react-native@842bcb9 should fix a regression on Android where suddenly some components are transparent. Would be nice to have cherry-picked if it applies cleanly.

Yea, seems I waiting this fix because after update to React native 0.65.0 a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button).

[kelset]

the 4 commits listed in the top post are cherry picked cleanly - already on the 0.65 branch. Local testing looks ✅ just waiting for a couple feedbacks then probably we'll do a quick 0.65.1 before end of the week

[gaodeng]

facebook/react-native#31461 RefreshControl causes an unwanted visual jump in the list content when the refreshing prop goes from true to false

The commit causing the problem is this one facebook/react-native@1b0fb9b, PR is this one facebook/react-native#28236
Can you revert this commit?

@dandre-hound it is safe to rollback this commit if you don't use navigation large headers. Will work on a fix asap.

Originally posted by the PR author @yogevbd in facebook/react-native#28236 (comment)

[dandre-hound]

Yeah, the team @tradehounds is surprised that this pull to refresh issue mentioned above has been present in the last two minor react-native releases. It's pretty disruptive to the user experience when using lists. It's also very easily reproducible and could be cleanly reverted. We've been waiting to upgrade until this is either reverted or a fix from the original PR author is merged in. Would love to see this commit reverted until then :)

[nextlevelbeard]

I believe the test automation community would highly appreciate these:
facebook/react-native@efb359f (facebook/react-native#31865)
facebook/react-native@91cac20 (facebook/react-native#31942)

Small but important fixes to the testID prop on Android builds.
It is currently not working with certain important components like TextInput and ScrollView.

[kelset]

hey folks, we wanted to make sure to do a quick patch with the few important fixes right away so we have already released a 0.65.1 release.

Let's move the conversation here for 0.65.2 -> #245 (which won't come out as fast)