Fixes #963 #974
Merged
Fixes #963 #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing! Could you please remove these lines too? I think these lines are no longer needed by this pr. |
Bug happens when uri is changed for a video. The fix: Remove player layer before addPlayerItemObservers so _playerItemObserversSet is still set to NO if observers have already been removed.
|
@masarusanjp - updated. Also re-ordered these lines so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #963
Bug happens when uri is changed for a video that is already rendered. This is because
[_playerLayer removeObserver:self forKeyPath:readyForDisplayKeyPath]is called twice because the_playerItemObserversSetvariable isn't properly set in sequence.The fix:
Remove player layer before addPlayerItemObservers so
_playerItemObserversSetis still set toNOif observers have already been removed.